Re: [PATCH 0/4] Add RISC-V semihosting support

[no-reply]

Patchew URL: 
20201028185722.2783532-1-keithp@keithp.com/">https://patchew.org/QEMU/20201028185722.2783532-1-keithp@keithp.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20201028185722.2783532-1-keithp@keithp.com
Subject: [PATCH 0/4] Add RISC-V semihosting support

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/20201028185722.2783532-1-keithp@keithp.com -> 
patchew/20201028185722.2783532-1-keithp@keithp.com
Switched to a new branch 'test'
5478e7a riscv: Add semihosting support [v11]
ead6a52 semihosting: Change internal common-semi interfaces to use CPUState *
2ec8e72 semihosting: Change common-semi API to be architecture-independent
f3a4c82 semihosting: Move ARM semihosting code to shared directories [v3]

=== OUTPUT BEGIN ===
1/4 Checking commit f3a4c823e594 (semihosting: Move ARM semihosting code to 
shared directories [v3])
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#71: 
rename from target/arm/arm-semi.c

total: 0 errors, 1 warnings, 46 lines checked

Patch 1/4 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/4 Checking commit 2ec8e72f8d0d (semihosting: Change common-semi API to be 
architecture-independent)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#66: 
new file mode 100644

total: 0 errors, 1 warnings, 163 lines checked

Patch 2/4 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/4 Checking commit ead6a524107d (semihosting: Change internal common-semi 
interfaces to use CPUState *)
ERROR: braces {} are necessary for all arms of this statement
#86: FILE: hw/semihosting/common-semi.c:142:
+    if (is_a64(env))
[...]
+    else
[...]

ERROR: braces {} are necessary for all arms of this statement
#97: FILE: hw/semihosting/common-semi.c:153:
+    if (is_a64(env))
[...]
+    else
[...]

WARNING: line over 80 characters
#205: FILE: hw/semihosting/common-semi.c:346:
+static void common_semi_flen_cb(CPUState *cs, target_ulong ret, target_ulong 
err)

WARNING: line over 80 characters
#213: FILE: hw/semihosting/common-semi.c:351:
+    cpu_memory_rw_debug(cs, common_semi_flen_buf(cs) + 32, (uint8_t *)&size, 
4, 0);

WARNING: line over 80 characters
#230: FILE: hw/semihosting/common-semi.c:360:
+static void common_semi_open_cb(CPUState *cs, target_ulong ret, target_ulong 
err)

WARNING: line over 80 characters
#257: FILE: hw/semihosting/common-semi.c:373:
+static target_ulong common_semi_gdb_syscall(CPUState *cs, 
gdb_syscall_complete_cb cb,

WARNING: line over 80 characters
#599: FILE: hw/semihosting/common-semi.c:765:
+            ret = common_semi_gdb_syscall(cs, common_semi_open_cb, 
"open,%s,%x,1a4", arg0,

WARNING: line over 80 characters
#600: FILE: hw/semihosting/common-semi.c:766:
+                                          (int)arg2+1, 
gdb_open_modeflags[arg1]);

ERROR: spaces required around that '+' (ctx:VxV)
#600: FILE: hw/semihosting/common-semi.c:766:
+                                          (int)arg2+1, 
gdb_open_modeflags[arg1]);
                                                    ^

ERROR: spaces required around that '+' (ctx:VxV)
#702: FILE: hw/semihosting/common-semi.c:863:
+                                          arg0, (int)arg1+1);
                                                          ^

WARNING: line over 80 characters
#722: FILE: hw/semihosting/common-semi.c:881:
+                                           arg0, (int)arg1+1, arg2, 
(int)arg3+1);

ERROR: spaces required around that '+' (ctx:VxV)
#722: FILE: hw/semihosting/common-semi.c:881:
+                                           arg0, (int)arg1+1, arg2, 
(int)arg3+1);
                                                           ^

ERROR: spaces required around that '+' (ctx:VxV)
#722: FILE: hw/semihosting/common-semi.c:881:
+                                           arg0, (int)arg1+1, arg2, 
(int)arg3+1);
                                                                              ^

ERROR: spaces required around that '+' (ctx:VxV)
#750: FILE: hw/semihosting/common-semi.c:907:
+                                           arg0, (int)arg1+1);
                                                           ^

total: 7 errors, 7 warnings, 767 lines checked

Patch 3/4 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

4/4 Checking commit 5478e7ae793d (riscv: Add semihosting support [v11])
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
20201028185722.2783532-1-keithp@keithp.com/testing.checkpatch/?type=message">http://patchew.org/logs/20201028185722.2783532-1-keithp@keithp.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com