[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 4/4] hw/riscv: virt: Add optional ACLINT support to virt m
|
From: |
Anup Patel |
|
Subject: |
Re: [PATCH v2 4/4] hw/riscv: virt: Add optional ACLINT support to virt machine |
|
Date: |
Fri, 27 Aug 2021 15:59:53 +0530 |
On Fri, Aug 6, 2021 at 8:00 AM Bin Meng <bmeng.cn@gmail.com> wrote:
>
> On Sat, Jul 24, 2021 at 8:27 PM Anup Patel <anup.patel@wdc.com> wrote:
> >
> > We extend virt machine to emulate ACLINT devices only when "aclint=on"
> > parameter is passed along with machine name in QEMU command-line.
> >
> > Signed-off-by: Anup Patel <anup.patel@wdc.com>
> > ---
> > hw/riscv/virt.c | 113 +++++++++++++++++++++++++++++++++++++++-
> > include/hw/riscv/virt.h | 2 +
> > 2 files changed, 114 insertions(+), 1 deletion(-)
> >
>
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
>
> Please add a "Machine-specific options" in the Virt documentation.
>
> See sifive_u example @
> https://qemu.readthedocs.io/en/latest/system/riscv/sifive_u.html#machine-specific-options
Okay, I will update the documentation in the next revision.
Regards,
Anup
>
> Regards,
> Bin