Re: [PATCH v4 00/21] target/riscv: Use tcg_constant

qemu-riscv

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 00/21] target/riscv: Use tcg_constant_*

From:	Richard Henderson
Subject:	Re: [PATCH v4 00/21] target/riscv: Use tcg_constant_*
Date:	Mon, 30 Aug 2021 08:26:58 -0700
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0

On 8/30/21 3:12 AM, Alistair Francis wrote:

On Sat, Aug 21, 2021 at 3:43 AM Richard Henderson
<richard.henderson@linaro.org> wrote:


Replace use of tcg_const_*, which makes a copy into a temp which must
be freed, with direct use of the constant.  Reorg handling of $zero,
with different accessors for source and destination.  Reorg handling
of csrs, passing the actual write_mask instead of a regno.  Use more
helpers for RVH expansion.

Patches lacking review:
   02-tests-tcg-riscv64-Add-test-for-division.patch
   03-target-riscv-Clean-up-division-helpers.patch
   11-target-riscv-Add-DisasExtend-to-gen_unary.patch
   17-target-riscv-Use-gen_shift_imm_fn-for-slli_uw.patch
   21-target-riscv-Use-get-dest-_gpr-for-RVV.patch


This should be all reviewed now. Do you want me to take it or do you plan on it?


Please take it through the riscv tree.  Thanks for the review.


r~

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH v4 14/21] target/riscv: Use {get, dest}_gpr for integer load/store, (continued)
- [PATCH v4 14/21] target/riscv: Use {get, dest}_gpr for integer load/store, Richard Henderson, 2021/08/20
  - Re: [PATCH v4 14/21] target/riscv: Use {get, dest}_gpr for integer load/store, Alistair Francis, 2021/08/23
- [PATCH v4 13/21] target/riscv: Use get_gpr in branches, Richard Henderson, 2021/08/20
  - Re: [PATCH v4 13/21] target/riscv: Use get_gpr in branches, Alistair Francis, 2021/08/23
- [PATCH v4 16/21] target/riscv: Use {get,dest}_gpr for RVA, Richard Henderson, 2021/08/20
- [PATCH v4 18/21] target/riscv: Use {get,dest}_gpr for RVF, Richard Henderson, 2021/08/20
- [PATCH v4 19/21] target/riscv: Use {get,dest}_gpr for RVD, Richard Henderson, 2021/08/20
- [PATCH v4 20/21] target/riscv: Tidy trans_rvh.c.inc, Richard Henderson, 2021/08/20
- [PATCH v4 21/21] target/riscv: Use {get,dest}_gpr for RVV, Richard Henderson, 2021/08/20
- Re: [PATCH v4 00/21] target/riscv: Use tcg_constant_*, Alistair Francis, 2021/08/30
  - Re: [PATCH v4 00/21] target/riscv: Use tcg_constant_*, Richard Henderson <=
    - Re: [PATCH v4 00/21] target/riscv: Use tcg_constant_*, Alistair Francis, 2021/08/30

Prev by Date: [PATCH v3 4/5] hw/intc: sifive_plic: Convert the PLIC to use RISC-V CPU GPIO lines
Next by Date: [PATCH 0/8] RISC V partial support for 128-bit architecture
Previous by thread: Re: [PATCH v4 00/21] target/riscv: Use tcg_constant_*
Next by thread: Re: [PATCH v4 00/21] target/riscv: Use tcg_constant_*
Index(es):
- Date
- Thread