Re: [PATCH v3 14/14] target/riscv: Compute mstatus.sd on demand

qemu-riscv

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 14/14] target/riscv: Compute mstatus.sd on demand

From:	Richard Henderson
Subject:	Re: [PATCH v3 14/14] target/riscv: Compute mstatus.sd on demand
Date:	Sun, 17 Oct 2021 22:31:53 -0700
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0

On 10/17/21 9:52 PM, Alistair Francis wrote:

On Sun, Oct 17, 2021 at 3:32 AM Richard Henderson
<richard.henderson@linaro.org> wrote:


The position of this read-only field is dependent on the
current cpu width.  Rather than having to compute that
difference in many places, compute it only on read.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>


This means that the value reported by riscv_cpu_dump_state() and GDB
will both be incorrect though?


Yep.  Missed those; should have added another accessor.

Also, for the record, it changes the vmstate, but since a previous patch in the seriesbumped the version number for the split on misa, we can call all of a piece and ok.

r~

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH v3 01/14] target/riscv: Move cpu_get_tb_cpu_state out of line, (continued)
- [PATCH v3 01/14] target/riscv: Move cpu_get_tb_cpu_state out of line, Richard Henderson, 2021/10/16
- [PATCH v3 09/14] target/riscv: Replace DisasContext.w with DisasContext.ol, Richard Henderson, 2021/10/16
- [PATCH v3 07/14] target/riscv: Properly check SEW in amo_op, Richard Henderson, 2021/10/16
- [PATCH v3 12/14] target/riscv: Use gen_unary_per_ol for RVB, Richard Henderson, 2021/10/16
  - Re: [PATCH v3 12/14] target/riscv: Use gen_unary_per_ol for RVB, Alistair Francis, 2021/10/18
- [PATCH v3 11/14] target/riscv: Adjust trans_rev8_32 for riscv64, Richard Henderson, 2021/10/16
- [PATCH v3 10/14] target/riscv: Use gen_arith_per_ol for RVM, Richard Henderson, 2021/10/16
  - Re: [PATCH v3 10/14] target/riscv: Use gen_arith_per_ol for RVM, Alistair Francis, 2021/10/18
- [PATCH v3 14/14] target/riscv: Compute mstatus.sd on demand, Richard Henderson, 2021/10/16
  - Re: [PATCH v3 14/14] target/riscv: Compute mstatus.sd on demand, Alistair Francis, 2021/10/18
    - Re: [PATCH v3 14/14] target/riscv: Compute mstatus.sd on demand, Richard Henderson <=
    - Re: [PATCH v3 14/14] target/riscv: Compute mstatus.sd on demand, Alistair Francis, 2021/10/18
    - Re: [PATCH v3 14/14] target/riscv: Compute mstatus.sd on demand, Richard Henderson, 2021/10/18
- [PATCH v3 13/14] target/riscv: Use gen_shift*_per_ol for RVB, RVI, Richard Henderson, 2021/10/16
  - Re: [PATCH v3 13/14] target/riscv: Use gen_shift*_per_ol for RVB, RVI, Alistair Francis, 2021/10/18

Prev by Date: Re: [PATCH v3 14/14] target/riscv: Compute mstatus.sd on demand
Next by Date: Re: [PATCH v8 01/78] target/riscv: fix TB_FLAGS bits overlapping bug for rvv/rvh
Previous by thread: Re: [PATCH v3 14/14] target/riscv: Compute mstatus.sd on demand
Next by thread: Re: [PATCH v3 14/14] target/riscv: Compute mstatus.sd on demand
Index(es):
- Date
- Thread