Re: [PATCH v2 05/22] target/riscv: Allow setting CPU feature from machine/device emulation

[Anup Patel]

On Sat, Sep 4, 2021 at 8:42 PM Bin Meng <bmeng.cn@gmail.com> wrote:
>
> On Thu, Sep 2, 2021 at 7:42 PM Anup Patel <anup.patel@wdc.com> wrote:
> >
> > The machine or device emulation should be able to force set certain
> > CPU features because:
> > 1) We can have certain CPU features which are in-general optional
> >    but implemented by RISC-V CPUs on machine.
>
> on the machine
>
> > 2) We can have devices which require certain CPU feature. For example,
>
> a certain
>
> >    AIA IMSIC devices expects AIA CSRs implemented by RISC-V CPUs.
>
> expect

Okay, I will update the commit description based on the above comments.

Regards,
Anup

>
> >
> > Signed-off-by: Anup Patel <anup.patel@wdc.com>
> > ---
> >  target/riscv/cpu.c | 11 +++--------
> >  target/riscv/cpu.h |  5 +++++
> >  2 files changed, 8 insertions(+), 8 deletions(-)
> >
>
> Otherwise,
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>