Re: [PATCH 01/13] target/riscv: Sign extend pc for different ol

qemu-riscv

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 01/13] target/riscv: Sign extend pc for different ol

From:	Richard Henderson
Subject:	Re: [PATCH 01/13] target/riscv: Sign extend pc for different ol
Date:	Mon, 1 Nov 2021 06:29:57 -0400
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0

On 11/1/21 6:01 AM, LIU Zhiwei wrote:

+static void gen_set_pc(DisasContext *ctx, target_ulong dest)
+{
+    TCGv t = tcg_constant_tl(dest);
+    switch (get_ol(ctx)) {
+    case MXL_RV32:
+        tcg_gen_ext32s_tl(cpu_pc, t);


Don't compute with tcg to do what you can in C.  Dest is constant.

And I think that XL is more appropriate than OL (which *should* be the same, but stilllooks weird).


    if (get_xl(ctx) == MXL_RV32) {
        dest = (int32_t)dest;
    }
    tcg_gen_movi_tl(cpu_pc, dest);


r~

[Prev in Thread]

Current Thread

[Next in Thread]

Re: [PATCH 02/13] target/riscv: Extend pc for runtime pc write, (continued)
- [PATCH 11/13] target/riscv: Switch context in exception return, LIU Zhiwei, 2021/11/01
  - Re: [PATCH 11/13] target/riscv: Switch context in exception return, Richard Henderson, 2021/11/01
    - Re: [PATCH 11/13] target/riscv: Switch context in exception return, LIU Zhiwei, 2021/11/08
    - Re: [PATCH 11/13] target/riscv: Switch context in exception return, LIU Zhiwei, 2021/11/09
    - Re: [PATCH 11/13] target/riscv: Switch context in exception return, LIU Zhiwei, 2021/11/09
- [PATCH 04/13] target/riscv: Use gdb xml according to max mxlen, LIU Zhiwei, 2021/11/01
  - Re: [PATCH 04/13] target/riscv: Use gdb xml according to max mxlen, Richard Henderson, 2021/11/01
- [PATCH 01/13] target/riscv: Sign extend pc for different ol, LIU Zhiwei, 2021/11/01
  - Re: [PATCH 01/13] target/riscv: Sign extend pc for different ol, Richard Henderson <=
- [PATCH 05/13] target/riscv: Calculate address according to ol, LIU Zhiwei, 2021/11/01
  - Re: [PATCH 05/13] target/riscv: Calculate address according to ol, Richard Henderson, 2021/11/01
    - Re: [PATCH 05/13] target/riscv: Calculate address according to ol, LIU Zhiwei, 2021/11/01
- [PATCH 12/13] target/riscv: Don't save pc when exception return, LIU Zhiwei, 2021/11/01
  - Re: [PATCH 12/13] target/riscv: Don't save pc when exception return, Richard Henderson, 2021/11/01
- [PATCH 09/13] target/riscv: Adjust vector address with ol, LIU Zhiwei, 2021/11/01
  - Re: [PATCH 09/13] target/riscv: Adjust vector address with ol, Richard Henderson, 2021/11/01
    - Re: [PATCH 09/13] target/riscv: Adjust vector address with ol, LIU Zhiwei, 2021/11/08
    - Re: [PATCH 09/13] target/riscv: Adjust vector address with ol, Richard Henderson, 2021/11/09
    - Re: [PATCH 09/13] target/riscv: Adjust vector address with ol, LIU Zhiwei, 2021/11/09

Prev by Date: [PATCH 08/13] target/riscv: Fix check range for first fault only
Next by Date: Re: [PATCH 02/13] target/riscv: Extend pc for runtime pc write
Previous by thread: [PATCH 01/13] target/riscv: Sign extend pc for different ol
Next by thread: [PATCH 05/13] target/riscv: Calculate address according to ol
Index(es):
- Date
- Thread