qemu-riscv
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC 2/5] target/riscv: Introduce privilege version field in the CSR


From: Richard Henderson
Subject: Re: [RFC 2/5] target/riscv: Introduce privilege version field in the CSR ops.
Date: Mon, 24 Jan 2022 18:56:05 +1100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0

On 1/21/22 7:07 AM, Atish Patra wrote:
+    [CSR_VSTART]   = { "vstart",   vs,     read_vstart,  write_vstart, NULL,
+                                           NULL, NULL, PRIV_VERSION_1_12_0 },

I think adding all of these NULLs are hard to read.
Better to just add

    .min_priv_ver = PRIV_VERSION_1_12_0

to the existing entry.


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]