Re: [PATCH v3 1/2] hw/registerfields: add `FIELDx_1CLEAR()` macro

[Alistair Francis]

On Mon, Oct 17, 2022 at 3:59 PM Wilfred Mallawa
<wilfred.mallawa@opensource.wdc.com> wrote:
>
> From: Wilfred Mallawa <wilfred.mallawa@wdc.com>
>
> Adds a helper macro that implements the register `w1c`
> functionality.
>
> Ex:
>   uint32_t data = FIELD32_1CLEAR(val, REG, FIELD);
>
> If ANY bits of the specified `FIELD` is set
> then the respective field is cleared and returned to `data`.
>
> If the field is cleared (0), then no change and
> val is returned.
>
> Signed-off-by: Wilfred Mallawa <wilfred.mallawa@wdc.com>

Reviewed-by: Alistair Francis <alistair.francis@wdc.com>

Alistair

> ---
>  include/hw/registerfields.h | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
>
> diff --git a/include/hw/registerfields.h b/include/hw/registerfields.h
> index 1330ca77de..0b8404c2f7 100644
> --- a/include/hw/registerfields.h
> +++ b/include/hw/registerfields.h
> @@ -115,6 +115,28 @@
>                    R_ ## reg ## _ ## field ## _LENGTH, _v.v);              \
>      _d; })
>
> +/*
> + * Clear the specified field in storage if
> + * any field bits are set, else no changes made. Implements
> + * single/multi-bit `w1c`
> + *
> + */
> +#define FIELD8_1CLEAR(storage, reg, field)                                \
> +    (FIELD_EX8(storage, reg, field) ?                                     \
> +    FIELD_DP8(storage, reg, field, 0x00) : storage)
> +
> +#define FIELD16_1CLEAR(storage, reg, field)                               \
> +    (FIELD_EX16(storage, reg, field) ?                                    \
> +    FIELD_DP16(storage, reg, field, 0x00) : storage)
> +
> +#define FIELD32_1CLEAR(storage, reg, field)                               \
> +    (FIELD_EX32(storage, reg, field) ?                                    \
> +    FIELD_DP32(storage, reg, field, 0x00) : storage)
> +
> +#define FIELD64_1CLEAR(storage, reg, field)                               \
> +    (FIELD_EX64(storage, reg, field) ?                                    \
> +    FIELD_DP64(storage, reg, field, 0x00) : storage)
> +
>  #define FIELD_SDP8(storage, reg, field, val) ({                           \
>      struct {                                                              \
>          signed int v:R_ ## reg ## _ ## field ## _LENGTH;                  \
> --
> 2.37.3
>
>