[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 1/4] target/riscv: Add itrigger support when icount is not
From: |
Alex Bennée |
Subject: |
Re: [PATCH v1 1/4] target/riscv: Add itrigger support when icount is not enabled |
Date: |
Mon, 07 Nov 2022 15:58:26 +0000 |
User-agent: |
mu4e 1.9.1; emacs 28.2.50 |
LIU Zhiwei <zhiwei_liu@linux.alibaba.com> writes:
> On 2022/11/7 9:37, Alistair Francis wrote:
>> On Thu, Oct 13, 2022 at 4:32 PM LIU Zhiwei <zhiwei_liu@linux.alibaba.com>
>> wrote:
>>> When icount is not enabled, there is no API in QEMU that can get the
>>> guest instruction number.
>>>
>>> Translate the guest code in a way that each TB only has one instruction.
>> I don't think this is a great idea.
>>
>> Why can't we just require icount be enabled if a user wants this? Or
>> singlestep?
>
> This feature will only be used by users who want to run the native
> gdb on Linux. If we run QEMU as a service, after booting the kernel,
> we can't predicate whether the users will use native gdb.
>
> Besides, icount can't be enabled on MTTCG currently (I am working on
> this problem)
I'm curious as to what your approach is going to be to solve this one?
--
Alex Bennée