qemu-riscv
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] include: Don't include qemu/osdep.h


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH] include: Don't include qemu/osdep.h
Date: Mon, 12 Dec 2022 08:37:08 +0100
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.5.1

On 12/12/22 08:04, Markus Armbruster wrote:
docs/devel/style.rst mandates:

     The "qemu/osdep.h" header contains preprocessor macros that affect
     the behavior of core system headers like <stdint.h>.  It must be
     the first include so that core system headers included by external
     libraries get the preprocessor macros that QEMU depends on.

     Do not include "qemu/osdep.h" from header files since the .c file
     will have already included it.

A few violations have crept in.  Fix them.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
  bsd-user/qemu.h                 | 1 -
  crypto/block-luks-priv.h        | 1 -
  include/hw/cxl/cxl_host.h       | 1 -
  include/hw/input/pl050.h        | 1 -
  include/hw/tricore/triboard.h   | 1 -
  include/qemu/userfaultfd.h      | 1 -
  net/vmnet_int.h                 | 1 -
  qga/cutils.h                    | 1 -
  target/hexagon/hex_arch_types.h | 1 -
  target/hexagon/mmvec/macros.h   | 1 -
  target/riscv/pmu.h              | 1 -
  qga/cutils.c                    | 3 ++-
  12 files changed, 2 insertions(+), 12 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]