[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 07/15] hw/riscv: write initrd 'chosen' FDT inside riscv_load_
|
From: |
Bin Meng |
|
Subject: |
Re: [PATCH 07/15] hw/riscv: write initrd 'chosen' FDT inside riscv_load_initrd() |
|
Date: |
Fri, 23 Dec 2022 18:15:59 +0800 |
On Thu, Dec 22, 2022 at 2:24 AM Daniel Henrique Barboza
<dbarboza@ventanamicro.com> wrote:
>
> riscv_load_initrd() returns the initrd end addr while also writing a
> 'start' var to mark the addr start. These informations are being used
> just to write the initrd FDT node. Every existing caller of
> riscv_load_initrd() is writing the FDT in the same manner.
>
> We can simplify things by writing the FDT inside riscv_load_initrd(),
> sparing callers from having to manage start/end addrs to write the FDT
> themselves.
>
> An 'if (fdt)' check is already inserted at the end of the function
> because we'll end up using it later on with other boards that doesn´t
doesn't
> have a FDT.
>
> Cc: Palmer Dabbelt <palmer@dabbelt.com>
> Signed-off-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
> ---
> hw/riscv/boot.c | 18 ++++++++++++------
> hw/riscv/microchip_pfsoc.c | 10 ++--------
> hw/riscv/sifive_u.c | 10 ++--------
> hw/riscv/spike.c | 10 ++--------
> hw/riscv/virt.c | 10 ++--------
> include/hw/riscv/boot.h | 4 ++--
> 6 files changed, 22 insertions(+), 40 deletions(-)
>
Reviewed-by: Bin Meng <bmeng@tinylab.org>
- Re: [PATCH 04/15] hw/riscv/boot.c: make riscv_find_firmware() static, (continued)
- [PATCH 07/15] hw/riscv: write initrd 'chosen' FDT inside riscv_load_initrd(), Daniel Henrique Barboza, 2022/12/21
- Re: [PATCH 07/15] hw/riscv: write initrd 'chosen' FDT inside riscv_load_initrd(),
Bin Meng <=
- [PATCH 08/15] hw/riscv: write bootargs 'chosen' FDT after riscv_load_kernel(), Daniel Henrique Barboza, 2022/12/21
- [PATCH 09/15] hw/riscv/boot.c: use MachineState in riscv_load_initrd(), Daniel Henrique Barboza, 2022/12/21
- [PATCH 10/15] hw/riscv/boot.c: use MachineState in riscv_load_kernel(), Daniel Henrique Barboza, 2022/12/21
- [PATCH 11/15] hw/riscv/boot.c: consolidate all kernel init in riscv_load_kernel(), Daniel Henrique Barboza, 2022/12/21