[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 06/15] hw/riscv/spike.c: load initrd right after riscv_load_k

From: Daniel Henrique Barboza
Subject: Re: [PATCH 06/15] hw/riscv/spike.c: load initrd right after riscv_load_kernel()
Date: Mon, 26 Dec 2022 10:52:29 -0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0

On 12/26/22 10:49, Bin Meng wrote:
On Fri, Dec 23, 2022 at 6:04 PM Bin Meng <bmeng.cn@gmail.com> wrote:
On Thu, Dec 22, 2022 at 2:28 AM Daniel Henrique Barboza
<dbarboza@ventanamicro.com> wrote:
This will make the code more in line with what the other boards are
doing. We'll also avoid an extra check to machine->kernel_filename since
we already checked that before executing riscv_load_kernel().

Signed-off-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
  hw/riscv/spike.c | 31 +++++++++++++++----------------
  1 file changed, 15 insertions(+), 16 deletions(-)

Reviewed-by: Bin Meng <bmeng@tinylab.org>
This change unfortunately breaks the ELF boot on Spike.

I will propose a patch to fix such unexpected dependency.

Interesting.  This is one of the most benign changes I did, or so I thought.

I believe we should wait for you patch fixing it first.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]