Re: [PATCH 08/12] hw/riscv: spike: Remove the out-of-date comments

qemu-riscv

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 08/12] hw/riscv: spike: Remove the out-of-date comments

From:	Daniel Henrique Barboza
Subject:	Re: [PATCH 08/12] hw/riscv: spike: Remove the out-of-date comments
Date:	Tue, 27 Dec 2022 14:37:58 -0300
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0



On 12/27/22 03:48, Bin Meng wrote:

Spike machine now supports OpenSBI plain binary bios image, so the
comments are no longer valid.

Signed-off-by: Bin Meng <bmeng@tinylab.org>
---


Reviewed-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com>


  hw/riscv/spike.c | 5 -----
  1 file changed, 5 deletions(-)

diff --git a/hw/riscv/spike.c b/hw/riscv/spike.c
index 8606331f61..ab0a945f8b 100644
--- a/hw/riscv/spike.c
+++ b/hw/riscv/spike.c
@@ -256,11 +256,6 @@ static void spike_board_init(MachineState *machine)
      memory_region_add_subregion(system_memory, memmap[SPIKE_MROM].base,
                                  mask_rom);

- /*

-     * Not like other RISC-V machines that use plain binary bios images,
-     * keeping ELF files here was intentional because BIN files don't work
-     * for the Spike machine as HTIF emulation depends on ELF parsing.
-     */
      if (riscv_is_32bit(&s->soc[0])) {
          firmware_end_addr = riscv_find_and_load_firmware(machine,
                                      RISCV32_BIOS_BIN, memmap[SPIKE_DRAM].base,

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH 00/12] hw/riscv: Improve Spike HTIF emulation fidelity, Bin Meng, 2022/12/27
- [PATCH 03/12] hw/char: riscv_htif: Drop useless assignment of memory region, Bin Meng, 2022/12/27
  - Re: [PATCH 03/12] hw/char: riscv_htif: Drop useless assignment of memory region, Daniel Henrique Barboza, 2022/12/27
  - Re: [PATCH 03/12] hw/char: riscv_htif: Drop useless assignment of memory region, Alistair Francis, 2022/12/27
- [PATCH 08/12] hw/riscv: spike: Remove the out-of-date comments, Bin Meng, 2022/12/27
  - Re: [PATCH 08/12] hw/riscv: spike: Remove the out-of-date comments, Daniel Henrique Barboza <=
  - Re: [PATCH 08/12] hw/riscv: spike: Remove the out-of-date comments, Alistair Francis, 2022/12/27
- [PATCH 05/12] hw/char: riscv_htif: Move registers from CPUArchState to HTIFState, Bin Meng, 2022/12/27
  - Re: [PATCH 05/12] hw/char: riscv_htif: Move registers from CPUArchState to HTIFState, Daniel Henrique Barboza, 2022/12/27
  - Re: [PATCH 05/12] hw/char: riscv_htif: Move registers from CPUArchState to HTIFState, Alistair Francis, 2022/12/27
- [PATCH 09/12] hw/riscv/boot.c: make riscv_find_firmware() static, Bin Meng, 2022/12/27
- [PATCH 10/12] hw/riscv/boot.c: introduce riscv_default_firmware_name(), Bin Meng, 2022/12/27
- [PATCH 11/12] hw/riscv/boot.c: Introduce riscv_find_firmware(), Bin Meng, 2022/12/27
  - Re: [PATCH 11/12] hw/riscv/boot.c: Introduce riscv_find_firmware(), Daniel Henrique Barboza, 2022/12/27
  - Re: [PATCH 11/12] hw/riscv/boot.c: Introduce riscv_find_firmware(), Alistair Francis, 2022/12/27
- [PATCH 12/12] hw/riscv: spike: Decouple create_fdt() dependency to ELF loading, Bin Meng, 2022/12/27

Prev by Date: Re: [PATCH 05/12] hw/char: riscv_htif: Move registers from CPUArchState to HTIFState
Next by Date: Re: [PATCH 11/12] hw/riscv/boot.c: Introduce riscv_find_firmware()
Previous by thread: [PATCH 08/12] hw/riscv: spike: Remove the out-of-date comments
Next by thread: Re: [PATCH 08/12] hw/riscv: spike: Remove the out-of-date comments
Index(es):
- Date
- Thread