[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 08/12] hw/riscv: spike: Remove the out-of-date comments
|
From: |
Bin Meng |
|
Subject: |
[PATCH v2 08/12] hw/riscv: spike: Remove the out-of-date comments |
|
Date: |
Thu, 29 Dec 2022 17:18:24 +0800 |
Spike machine now supports OpenSBI plain binary bios image, so the
comments are no longer valid.
Signed-off-by: Bin Meng <bmeng@tinylab.org>
Reviewed-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
---
(no changes since v1)
hw/riscv/spike.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/hw/riscv/spike.c b/hw/riscv/spike.c
index 8606331f61..ab0a945f8b 100644
--- a/hw/riscv/spike.c
+++ b/hw/riscv/spike.c
@@ -256,11 +256,6 @@ static void spike_board_init(MachineState *machine)
memory_region_add_subregion(system_memory, memmap[SPIKE_MROM].base,
mask_rom);
- /*
- * Not like other RISC-V machines that use plain binary bios images,
- * keeping ELF files here was intentional because BIN files don't work
- * for the Spike machine as HTIF emulation depends on ELF parsing.
- */
if (riscv_is_32bit(&s->soc[0])) {
firmware_end_addr = riscv_find_and_load_firmware(machine,
RISCV32_BIOS_BIN, memmap[SPIKE_DRAM].base,
--
2.34.1
- [PATCH v2 00/12] hw/riscv: Improve Spike HTIF emulation fidelity, Bin Meng, 2022/12/29
- [PATCH v2 03/12] hw/char: riscv_htif: Drop useless assignment of memory region, Bin Meng, 2022/12/29
- [PATCH v2 05/12] hw/char: riscv_htif: Move registers from CPUArchState to HTIFState, Bin Meng, 2022/12/29
- [PATCH v2 08/12] hw/riscv: spike: Remove the out-of-date comments,
Bin Meng <=
- [PATCH v2 09/12] hw/riscv/boot.c: make riscv_find_firmware() static, Bin Meng, 2022/12/29
- [PATCH v2 11/12] hw/riscv/boot.c: Introduce riscv_find_firmware(), Bin Meng, 2022/12/29
- [PATCH v2 10/12] hw/riscv/boot.c: introduce riscv_default_firmware_name(), Bin Meng, 2022/12/29
- Re: [PATCH v2 00/12] hw/riscv: Improve Spike HTIF emulation fidelity, Daniel Henrique Barboza, 2022/12/29
- [PATCH v2 12/12] hw/riscv: spike: Decouple create_fdt() dependency to ELF loading, Bin Meng, 2022/12/29