Re: [PATCH v4 04/11] hw/riscv/boot.c: exit early if filename is NULL in

qemu-riscv

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 04/11] hw/riscv/boot.c: exit early if filename is NULL in

From:	Philippe Mathieu-Daudé
Subject:	Re: [PATCH v4 04/11] hw/riscv/boot.c: exit early if filename is NULL in load_(kernel\|initrd)
Date:	Fri, 30 Dec 2022 13:50:01 +0100
User-agent:	Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1

On 30/12/22 09:58, Bin Meng wrote:

On Fri, Dec 30, 2022 at 2:21 AM Daniel Henrique Barboza
<dbarboza@ventanamicro.com> wrote:


riscv_load_kernel() and riscv_load_initrd() works under the assumption
that 'kernel_filename' and 'filename' are not NULL.


We should do the same in riscv_load_firmware()


Can be done on top IMHO.

This is currently the case since all callers of both functions are
checking for NULL before calling them. Put an assert in both to make
sure that a NULL value for both cases would be considered a bug.

Suggested-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
---
  hw/riscv/boot.c | 4 ++++
  1 file changed, 4 insertions(+)


Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH v4 00/11] riscv: OpenSBI boot test and cleanups, Daniel Henrique Barboza, 2022/12/29
- [PATCH v4 01/11] tests/avocado: add RISC-V OpenSBI boot test, Daniel Henrique Barboza, 2022/12/29
  - Re: [PATCH v4 01/11] tests/avocado: add RISC-V OpenSBI boot test, Philippe Mathieu-Daudé, 2022/12/30
- [PATCH v4 02/11] hw/riscv/spike: use 'fdt' from MachineState, Daniel Henrique Barboza, 2022/12/29
- [PATCH v4 03/11] hw/riscv/sifive_u: use 'fdt' from MachineState, Daniel Henrique Barboza, 2022/12/29
- [PATCH v4 04/11] hw/riscv/boot.c: exit early if filename is NULL in load_(kernel|initrd), Daniel Henrique Barboza, 2022/12/29
  - Re: [PATCH v4 04/11] hw/riscv/boot.c: exit early if filename is NULL in load_(kernel|initrd), Bin Meng, 2022/12/30
    - Re: [PATCH v4 04/11] hw/riscv/boot.c: exit early if filename is NULL in load_(kernel|initrd), Philippe Mathieu-Daudé <=
- [PATCH v4 05/11] hw/riscv/spike.c: load initrd right after riscv_load_kernel(), Daniel Henrique Barboza, 2022/12/29
- [PATCH v4 06/11] hw/riscv: write initrd 'chosen' FDT inside riscv_load_initrd(), Daniel Henrique Barboza, 2022/12/29
  - Re: [PATCH v4 06/11] hw/riscv: write initrd 'chosen' FDT inside riscv_load_initrd(), Philippe Mathieu-Daudé, 2022/12/30
- [PATCH v4 07/11] hw/riscv: write bootargs 'chosen' FDT after riscv_load_kernel(), Daniel Henrique Barboza, 2022/12/29
  - Re: [PATCH v4 07/11] hw/riscv: write bootargs 'chosen' FDT after riscv_load_kernel(), Philippe Mathieu-Daudé, 2022/12/30
- [PATCH v4 08/11] hw/riscv/boot.c: use MachineState in riscv_load_initrd(), Daniel Henrique Barboza, 2022/12/29
- [PATCH v4 09/11] hw/riscv/boot.c: use MachineState in riscv_load_kernel(), Daniel Henrique Barboza, 2022/12/29
- [PATCH v4 10/11] hw/riscv/boot.c: introduce riscv_load_kernel_and_initrd(), Daniel Henrique Barboza, 2022/12/29
  - Re: [PATCH v4 10/11] hw/riscv/boot.c: introduce riscv_load_kernel_and_initrd(), Bin Meng, 2022/12/30
    - Re: [PATCH v4 10/11] hw/riscv/boot.c: introduce riscv_load_kernel_and_initrd(), Daniel Henrique Barboza, 2022/12/30

Prev by Date: Re: [PATCH v4 10/11] hw/riscv/boot.c: introduce riscv_load_kernel_and_initrd()
Next by Date: Re: [PATCH v4 01/11] tests/avocado: add RISC-V OpenSBI boot test
Previous by thread: Re: [PATCH v4 04/11] hw/riscv/boot.c: exit early if filename is NULL in load_(kernel|initrd)
Next by thread: [PATCH v4 05/11] hw/riscv/spike.c: load initrd right after riscv_load_kernel()
Index(es):
- Date
- Thread