[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 00/19] Clean up includes
From: |
Markus Armbruster |
Subject: |
Re: [PATCH v4 00/19] Clean up includes |
Date: |
Thu, 19 Jan 2023 10:20:16 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) |
Markus Armbruster <armbru@redhat.com> writes:
> Back in 2016, we discussed[1] rules for headers, and these were
> generally liked:
>
> 1. Have a carefully curated header that's included everywhere first. We
> got that already thanks to Peter: osdep.h.
>
> 2. Headers should normally include everything they need beyond osdep.h.
> If exceptions are needed for some reason, they must be documented in
> the header. If all that's needed from a header is typedefs, put
> those into qemu/typedefs.h instead of including the header.
>
> 3. Cyclic inclusion is forbidden.
>
> This series fixes violations of rule 2. I may have split patches too
> aggressively. Let me know if you want some squashed together.
>
> v4:
> * PATCH 01-03: New
> * PATCH 04-15: Previous version redone with scripts/clean-includes,
> result split up for review
Copying the R-bys for v3 to these patches is tempting. But I didn't.
> * PATCH 16-19: New
>
> v3:
> * Rebased, old PATCH 1+2+4 are in master as commit
> 881e019770..f07ceffdf5
> * PATCH 1: Fix bsd-user
>
> v2:
> * Rebased
> * PATCH 3: v1 posted separately
> * PATCH 4: New
>
> [1] Message-ID: <87h9g8j57d.fsf@blackfin.pond.sub.org>
> https://lists.nongnu.org/archive/html/qemu-devel/2016-03/msg03345.html
[PATCH v4 06/19] hw/cxl: Clean up includes, Markus Armbruster, 2023/01/19
[PATCH v4 11/19] net: Clean up includes, Markus Armbruster, 2023/01/19
Re: [PATCH v4 00/19] Clean up includes,
Markus Armbruster <=
Re: [PATCH v4 00/19] Clean up includes, Michael S. Tsirkin, 2023/01/19