qemu-riscv
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 05/18] target/riscv: gdbstub: Do not generate CSR XML if Z


From: LIU Zhiwei
Subject: Re: [PATCH v2 05/18] target/riscv: gdbstub: Do not generate CSR XML if Zicsr is disabled
Date: Thu, 2 Mar 2023 10:43:39 +0800
User-agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0


On 2023/3/2 8:30, Bin Meng wrote:
On Thu, Mar 2, 2023 at 7:43 AM Palmer Dabbelt <palmer@dabbelt.com> wrote:
On Wed, 01 Mar 2023 01:55:34 PST (-0800), Bin Meng wrote:
On Wed, Mar 1, 2023 at 5:52 PM LIU Zhiwei <zhiwei_liu@linux.alibaba.com> wrote:

On 2023/2/28 18:40, Bin Meng wrote:
There is no need to generate the CSR XML if the Zicsr extension
is not enabled.
Should we generate the FPU XML or Vector XML when Zicsr is not enabled?
Good point. I think we should disable that too.
Seems reasonable.  Did you want to do that as part of a v3, or just as a
follow-on fix?

I looked at this further.

The FPU / Vector XML is guarded by the " env->misa_ext" check. If
Zicsr is disabled while F or V extension is off, QEMU will error out
in riscv_cpu_realize() earlier before the gdbstub init.

Make sense.

Zhiwei


So current patch should be fine.

Regards,
Bin



reply via email to

[Prev in Thread] Current Thread [Next in Thread]