Re: [PATCH v1 1/1] s390x: css: report errors from ccw_dstream_read/write

[Cornelia Huck]

On Thu, 8 Apr 2021 14:32:11 +0200
Pierre Morel <pmorel@linux.ibm.com> wrote:

> On 4/8/21 11:02 AM, Cornelia Huck wrote:
> > On Wed, 7 Apr 2021 19:47:11 +0200
> > Halil Pasic <pasic@linux.ibm.com> wrote:
> >   
> >> So this begs the question, do we need this fixed for old releases as well?
> >>
> >> My answer is yes we do. Conny what do you think?  
> > 
> > What do you mean with "old releases"? The dstream rework was in 2.11,
> > and I doubt that anyone is using anything older, or a downstream
> > release that is based on pre-2.11.
> > 
> > If you mean "include in stable", then yes, we can do that; if we want
> > the commit in 6.0, I need the final version soon.
> > 
> >   
> 
> OK, are you OK with the two change propositions I sent?
> 
> 1) let the 3270 decide for internal errors (-EIO) but return the error 
> for CSS errors in handle_payload_3270_write()
> 
> 2) for senseid, always ask CSS to update the residual count
> but only erase the senseid if the write succeeded
> 
> 

I think both make sense.