Re: [PATCH-for-8.0 1/2] target/s390x: Replace TCGv by TCGv_i64 in op_mov2e()

[Philippe Mathieu-Daudé]

On 1/12/22 13:36, Ilya Leoshkevich wrote:
> On Wed, 2022-11-30 at 17:34 +0100, Philippe Mathieu-Daudé wrote:
> > Although TCGv is defined as TCGv_i64 on s390x,
> > make it clear tcg_temp_new_i64() returns a TCGv_i64.
> >
> > Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> > ---
> >   target/s390x/tcg/translate.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/target/s390x/tcg/translate.c
> > b/target/s390x/tcg/translate.c
> > index 1e599ac259..a77039b863 100644
> > --- a/target/s390x/tcg/translate.c
> > +++ b/target/s390x/tcg/translate.c
> > @@ -3335,7 +3335,7 @@ static DisasJumpType op_mov2(DisasContext *s,
> > DisasOps *o)
> >   static DisasJumpType op_mov2e(DisasContext *s, DisasOps *o)
> >   {
> >       int b2 = get_field(s, b2);
> > -    TCGv ar1 = tcg_temp_new_i64();
> > +    TCGv_i64 ar1 = tcg_temp_new_i64();
> >   
> >       o->out = o->in2;
> >       o->g_out = o->g_in2;
>
> Reviewed-by: Ilya Leoshkevich <iii@linux.ibm.com>
>
> It looks as if besides sparc and s390x there is one occurrence of this
> in alpha?
>
> $ git grep -w TCGv | grep -w tcg_temp_new_i64
> target/alpha/translate.c:    TCGv tmp = tcg_temp_new_i64();

Oh I missed it, thanks!