Re: [PATCH v13 2/7] s390x/cpu topology: reporting the CPU topology to the guest

[Pierre Morel]

On 12/9/22 16:43, Cédric Le Goater wrote:
> On 12/8/22 10:44, Pierre Morel wrote:
> > The guest uses the STSI instruction to get information on the
> > CPU topology.
> >
> > Let us implement the STSI instruction for the basis CPU topology
> > level, level 2.
> >
> > Signed-off-by: Pierre Morel <pmorel@linux.ibm.com>
> > ---

...

> > +#define S390_TOPOLOGY_MAX_MNEST 2
> > +
> > +void insert_stsi_15_1_x(S390CPU *cpu, int sel2, __u64 addr, uint8_t ar)
> > +{
> > +    union {
> > +        char place_holder[S390_TOPOLOGY_SYSIB_SIZE];
> > +        SysIB_151x sysib;
> > +    } buffer QEMU_ALIGNED(8);
> > +    int len;
> > +
> > +    if (s390_is_pv() || !s390_has_topology() ||
>
> Isn't the test s390_is_pv() redundant since patch 6 deactivates
> S390_FEAT_CONFIGURATION_TOPOLOGY for PV guests ?

Yes you are right it is.
I remove it.

Regards,
Pierre



--
Pierre Morel
IBM Lab Boeblingen