Re: [PATCH] gtk: disable GTK Clipboard with a new option 'gtk_clipboard'

[Peter Maydell]

On Fri, 18 Nov 2022 at 22:26, Jim Fehlig <jfehlig@suse.com> wrote:
>
> I should make myself useful around here on occasion when items are within my
> skill set. But I already struggle to find time for that in the libvirt 
> community
> :-).
>
> On 11/8/22 09:23, Claudio Fontana wrote:
> > The GTK Clipboard implementation may cause guest hangs.
> >
> > Therefore implement a new configure switch --enable-gtk-clipboard,
> > disabled by default, as a meson option.
> >
> > Regenerate the meson build options to include it.
> >
> > The initialization of the clipboard is gtk.c, as well as the
> > compilation of gtk-clipboard.c are now conditional on this new option
> > to be set.

> > diff --git a/scripts/meson-buildoptions.sh b/scripts/meson-buildoptions.sh
> > index 2cb0de5601..a542853bfd 100644
> > --- a/scripts/meson-buildoptions.sh
> > +++ b/scripts/meson-buildoptions.sh
> > @@ -93,6 +93,7 @@ meson_options_help() {
> >     printf "%s\n" '  glusterfs       Glusterfs block device driver'
> >     printf "%s\n" '  gnutls          GNUTLS cryptography support'
> >     printf "%s\n" '  gtk             GTK+ user interface'
> > +  printf "%s\n" '  gtk-clipboard   clipboard support for the gtk UI 
> > (EXPERIMENTAL, MAY HANG)'
>
> Same here. None of the other options have such warning. Cant this be treated
> like the others, just another option to be enabled or disabled? Whether or not
> the option works is another matter.

Well, none of the other features have known bugs that cause QEMU to hang...

-- PMM