[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 07/11] vfio/platform: Remove dead assignment in vfio_intp_int
From: |
Auger Eric |
Subject: |
Re: [PATCH 07/11] vfio/platform: Remove dead assignment in vfio_intp_interrupt() |
Date: |
Thu, 13 Aug 2020 11:25:42 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
Hi,
On 8/13/20 9:37 AM, Chen Qun wrote:
> Clang static code analyzer show warning:
> hw/vfio/platform.c:239:9: warning: Value stored to 'ret' is never read
> ret = event_notifier_test_and_clear(intp->interrupt);
> ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Reported-by: Euler Robot <euler.robot@huawei.com>
> Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
Reviewed-by: Eric Auger <eric.auger@redhat.com>
Thanks
Eric
> ---
> Cc: Alex Williamson <alex.williamson@redhat.com>
> Cc: Eric Auger <eric.auger@redhat.com>
> ---
> hw/vfio/platform.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/vfio/platform.c b/hw/vfio/platform.c
> index ac2cefc9b1..869ed2c39d 100644
> --- a/hw/vfio/platform.c
> +++ b/hw/vfio/platform.c
> @@ -236,7 +236,7 @@ static void vfio_intp_interrupt(VFIOINTp *intp)
> trace_vfio_intp_interrupt_set_pending(intp->pin);
> QSIMPLEQ_INSERT_TAIL(&vdev->pending_intp_queue,
> intp, pqnext);
> - ret = event_notifier_test_and_clear(intp->interrupt);
> + event_notifier_test_and_clear(intp->interrupt);
> return;
> }
>
>
- [PATCH 00/11] trivial patchs for static code analyzer fixes, Chen Qun, 2020/08/13
- [PATCH 07/11] vfio/platform: Remove dead assignment in vfio_intp_interrupt(), Chen Qun, 2020/08/13
- Re: [PATCH 07/11] vfio/platform: Remove dead assignment in vfio_intp_interrupt(),
Auger Eric <=
- Re: [PATCH 07/11] vfio/platform: Remove dead assignment in vfio_intp_interrupt(), Alex Williamson, 2020/08/13
- Re: [PATCH 07/11] vfio/platform: Remove dead assignment in vfio_intp_interrupt(), Auger Eric, 2020/08/13
- Re: [PATCH 07/11] vfio/platform: Remove dead assignment in vfio_intp_interrupt(), Alex Williamson, 2020/08/13
- Re: [PATCH 07/11] vfio/platform: Remove dead assignment in vfio_intp_interrupt(), Auger Eric, 2020/08/13
- Re: [PATCH 07/11] vfio/platform: Remove dead assignment in vfio_intp_interrupt(), Stefan Hajnoczi, 2020/08/18
- Re: [PATCH 07/11] vfio/platform: Remove dead assignment in vfio_intp_interrupt(), Auger Eric, 2020/08/18
[PATCH 05/11] hw/virtio/vhost-user:Remove dead assignment in scrub_shadow_regions(), Chen Qun, 2020/08/13
[PATCH 09/11] usb/bus: Remove dead assignment in usb_get_fw_dev_path(), Chen Qun, 2020/08/13