[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 09/10] hw/intc: fix default registers value in exynos4210_
From: |
Peter Maydell |
Subject: |
Re: [PATCH v3 09/10] hw/intc: fix default registers value in exynos4210_combiner_read() |
Date: |
Thu, 27 Aug 2020 12:06:53 +0100 |
On Thu, 27 Aug 2020 at 12:04, Chen Qun <kuhn.chenqun@huawei.com> wrote:
>
> Clang static code analyzer show warning:
> hw/intc/exynos4210_combiner.c:231:9: warning: Value stored to 'val' is never
> read
> val = s->reg_set[offset >> 2];
>
> The default register return value should be return 'val'.
>
> Reported-by: Euler Robot <euler.robot@huawei.com>
> Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
> ---
> Cc: Igor Mitsyanko <i.mitsyanko@gmail.com>
> Cc: Peter Maydell <peter.maydell@linaro.org>
>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
- [PATCH v3 00/10] trivial patchs for static code analyzer fixes, Chen Qun, 2020/08/27
- [PATCH v3 04/10] target/arm/translate-a64:Remove redundant statement in disas_simd_two_reg_misc_fp16(), Chen Qun, 2020/08/27
- [PATCH v3 01/10] hw/arm/virt-acpi-build:Remove dead assignment in build_madt(), Chen Qun, 2020/08/27
- [PATCH v3 02/10] hw/arm/omap1:Remove redundant statement in omap_clkdsp_read(), Chen Qun, 2020/08/27
- [PATCH v3 03/10] target/arm/translate-a64:Remove dead assignment in handle_scalar_simd_shli(), Chen Qun, 2020/08/27
- [PATCH v3 07/10] vfio/platform: Remove dead assignment in vfio_intp_interrupt(), Chen Qun, 2020/08/27
- [PATCH v3 06/10] hw/net/virtio-net:Remove redundant statement in virtio_net_rsc_tcp_ctrl_check(), Chen Qun, 2020/08/27
- [PATCH v3 10/10] hw/display/vga:Remove redundant statement in vga_draw_graphic(), Chen Qun, 2020/08/27
- [PATCH v3 05/10] hw/virtio/vhost-user:Remove dead assignment in scrub_shadow_regions(), Chen Qun, 2020/08/27
- [PATCH v3 09/10] hw/intc: fix default registers value in exynos4210_combiner_read(), Chen Qun, 2020/08/27
- Re: [PATCH v3 09/10] hw/intc: fix default registers value in exynos4210_combiner_read(),
Peter Maydell <=
- [PATCH v3 08/10] usb/bus: Remove dead assignment in usb_get_fw_dev_path(), Chen Qun, 2020/08/27