[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Fix typo in CFI build documentation
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH] Fix typo in CFI build documentation |
Date: |
Wed, 21 Apr 2021 15:55:22 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 |
Hi Serge,
Cc'ing qemu-trivial@
On 4/20/21 5:48 PM, serge-sans-paille wrote:
> Signed-off-by: serge-sans-paille <sguelton@redhat.com>
It looks your git-config is misconfigured... Maybe you used
an incorrect profile :) Can you repost please?
> ---
> docs/devel/control-flow-integrity.rst | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
For the fix:
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>
> diff --git a/docs/devel/control-flow-integrity.rst
> b/docs/devel/control-flow-integrity.rst
> index d89d707..e6b73a4 100644
> --- a/docs/devel/control-flow-integrity.rst
> +++ b/docs/devel/control-flow-integrity.rst
> @@ -39,7 +39,7 @@ later).
> Given the use of LTO, a version of AR that supports LLVM IR is required.
> The easies way of doing this is by selecting the AR provided by LLVM::
>
> - AR=llvm-ar-9 CC=clang-9 CXX=lang++-9 /path/to/configure --enable-cfi
> + AR=llvm-ar-9 CC=clang-9 CXX=clang++-9 /path/to/configure --enable-cfi
>
> CFI is enabled on every binary produced.
>
> @@ -131,7 +131,7 @@ lld with version 11+.
> In other words, to compile with fuzzing and CFI, clang 11+ is required, and
> lld needs to be used as a linker::
>
> - AR=llvm-ar-11 CC=clang-11 CXX=lang++-11 /path/to/configure --enable-cfi \
> + AR=llvm-ar-11 CC=clang-11 CXX=clang++-11 /path/to/configure --enable-cfi \
> -enable-fuzzing --extra-ldflags="-fuse-ld=lld"
>
> and then, compile the fuzzers as usual.
>
- Re: [PATCH] Fix typo in CFI build documentation,
Philippe Mathieu-Daudé <=