[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] bsd-user: Only process meson rules on BSD host
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH 1/2] bsd-user: Only process meson rules on BSD host |
Date: |
Mon, 27 Sep 2021 07:24:11 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 |
On 9/27/21 01:08, Richard Henderson wrote:
> On 9/26/21 6:01 PM, Philippe Mathieu-Daudé wrote:
>> Reported-by: Warner Losh <imp@bsdimp.com>
>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>> ---
>> bsd-user/meson.build | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/bsd-user/meson.build b/bsd-user/meson.build
>> index 03695493408..a7607e1c884 100644
>> --- a/bsd-user/meson.build
>> +++ b/bsd-user/meson.build
>> @@ -1,3 +1,7 @@
>> +if not config_host.has_key('CONFIG_BSD')
>> + subdir_done()
>> +endif
>
> Why here and not in the parent meson.build?
This is what Paolo recommended me to do last time I added a
conditional inclusion.
Personally I prefer having it in the call site rather than
the callee (no need to read the callee to notice it isn't
called). I guess this is for readability, to not clutter
meson.build files more...
Paolo, what is your preference?
[PATCH 2/2] linux-user: Only process meson rules on Linux host, Philippe Mathieu-Daudé, 2021/09/26