[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] target/i386: Include 'hw/i386/apic.h' locally
From: |
Laurent Vivier |
Subject: |
Re: [PATCH] target/i386: Include 'hw/i386/apic.h' locally |
Date: |
Wed, 29 Sep 2021 17:16:50 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 |
Le 29/09/2021 à 17:00, Laurent Vivier a écrit :
> Le 29/09/2021 à 16:08, Philippe Mathieu-Daudé a écrit :
>> On 9/16/21 00:05, Paolo Bonzini wrote:
>>> On 02/09/21 17:22, Philippe Mathieu-Daudé wrote:
>>>> Instead of including a sysemu-specific header in "cpu.h"
>>>> (which is shared with user-mode emulations), include it
>>>> locally when required.
>>>>
>>>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>>>> ---
>>>
>>> Acked-by: Paolo Bonzini <pbonzini@redhat.com>
>>
>> Thank you, Cc'ing qemu-trivial@ :)
>>
>
> Applied to my trivial-patches branch.
>
We have a problem:
.../target/i386/tcg/sysemu/seg_helper.c:145:9: error: implicit declaration of
function
'apic_poll_irq' [-Werror=implicit-function-declaration]
145 | apic_poll_irq(cpu->apic_state);
| ^~~~~~~~~~~~~
.../target/i386/tcg/sysemu/seg_helper.c:145:9: error: nested extern declaration
of 'apic_poll_irq'
[-Werror=nested-externs]