Re: [PATCH v2 0/3] QOM improvements for rtc/mc146818rtc

[Philippe Mathieu-Daudé]

On 22/5/22 22:43, Bernhard Beschow wrote:
> v2:
> * Explicitly fail with &error_abort rather than NULL (Mark)
> * Explicitly fail with &error_abort rather than NULL in existing code (me)
> * Unexport rather than remove RTC_ISA_BASE (Mark)
> * Use object_property_get_*u*int() also for "iobase" (me)
>
> v1:
> This little series enhances QOM support for mc146818rtc:
> * makes microvm-dt respect mc146818rtc's IRQ number set by QOM property and
> * adds an io_base QOM property similar to other ISA devices
>
> Bernhard Beschow (3):
>    hw/i386/microvm-dt: Force explicit failure if retrieving QOM property
>      fails
>    hw/i386/microvm-dt: Determine mc146818rtc's IRQ number from QOM
>      property
>    rtc/mc146818rtc: QOM'ify io_base offset

In patch 3 "iobase" could be u16. Otherwise,

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>