[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH trivial for 7.2] hw/ssi/sifive_spi.c: spelling: reigster
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH trivial for 7.2] hw/ssi/sifive_spi.c: spelling: reigster |
|
Date: |
Wed, 9 Nov 2022 08:50:31 +0100 |
|
User-agent: |
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 |
On 8/11/22 23:11, Palmer Dabbelt wrote:
On Sat, 05 Nov 2022 04:53:29 PDT (-0700), mjt@tls.msk.ru wrote:
Fixes: 0694dabe9763847f3010b54ab3ec7d367d2f0ff0
Not sure if I missed something in QEMU land, but those are usually
listed more like
Fixes: 0694dabe97 ("hw/ssi: Add SiFive SPI controller support")
MST suggested once to try to restrict the 'Fixes:' tag to bug /
regressions, as it might help downstream distributions to filter
commits to cherry-pick.
Since it might be useful to have the offending commit sha1 in the
description, when it is simply an omission or improvement I use
the an inline form instead of a tag:
Fixes the typo introduced in commit 0694dabe97 ("hw/ssi: Add SiFive
SPI controller support").
Although in this particular use-case it is not really useful ;)
Another example:
When adding <the feature> in commit <sha1 ("<subject>")>, we forgot
to fill the API prototype description. Do it now.
Regards,
Phil.