Re: [PATCH] acpi/tests/avocado/bits: add SPDX license identifiers for bios bits tests

[Ani Sinha]

On Thu, Nov 24, 2022 at 7:47 PM Michael S. Tsirkin <mst@redhat.com> wrote:
>
> On Thu, Nov 24, 2022 at 07:28:34PM +0530, Ani Sinha wrote:
> > Added the SPDX license identifiers for biosbits tests.
> > Also added a comment on each of the test scripts to indicate that they run
> > from within the biosbits environment and hence are not subjected to the 
> > regular
> > maintanance acivities
>
>
> activities?

This came from John's suggestion here:
https://www.mail-archive.com/qemu-devel@nongnu.org/msg899480.html .

"Could I please ask for a comment in each .py file that isn't designed
to run directly in the host v/environment? Just a small nod to the fact
that it runs in a special VM so I can exclude it from other regular
maintenance operations / considerations for dependency management in the
host testing env.

# Designed to run only in the biosbits VM.

would be more than sufficient.
"
I can reword this in any way that sounds better.

>
> > for QEMU and is excluded from the dependency management
> > challenges in the host testing environment.
> >
> > Cc: Daniel P. Berrangé <berrange@redhat.com>
> > Cc: Paolo Bonzini <pbonzini@redhat.com>
> > Cc: Maydell Peter <peter.maydell@linaro.org>
> > Cc: John Snow <jsnow@redhat.com>
> > Cc: Thomas Huth <thuth@redhat.com>
> > Cc: Alex Bennée <alex.bennee@linaro.org>
> > Cc: Igor Mammedov <imammedo@redhat.com>
> > Cc: Michael Tsirkin <mst@redhat.com>
> > Cc: Thomas Huth <thuth@redhat.com>
> > Cc: qemu-trivial@nongnu.org
> > Signed-off-by: Ani Sinha <ani@anisinha.ca>
> > ---
> >  tests/avocado/acpi-bits/bits-tests/smbios.py2    | 4 ++++
> >  tests/avocado/acpi-bits/bits-tests/testacpi.py2  | 4 ++++
> >  tests/avocado/acpi-bits/bits-tests/testcpuid.py2 | 4 ++++
> >  3 files changed, 12 insertions(+)
> >
> > Apologies for this. Somehow this patch fell off my tree between multiple
> > revisions. Quite trivial and does not affect any QEMU codebase.
> >
> > diff --git a/tests/avocado/acpi-bits/bits-tests/smbios.py2 
> > b/tests/avocado/acpi-bits/bits-tests/smbios.py2
> > index 9667d0542c..fc623de072 100644
> > --- a/tests/avocado/acpi-bits/bits-tests/smbios.py2
> > +++ b/tests/avocado/acpi-bits/bits-tests/smbios.py2
> > @@ -1,6 +1,8 @@
> >  # Copyright (c) 2015, Intel Corporation
> >  # All rights reserved.
> >  #
> > +# SPDX-License-Identifier: BSD-3-Clause
> > +#
> >  # Redistribution and use in source and binary forms, with or without
> >  # modification, are permitted provided that the following conditions are 
> > met:
> >  #
> > @@ -24,6 +26,8 @@
> >  # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF 
> > THIS
> >  # SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
> >
> > +# This script runs only from the biosbits VM.
> > +
> >  """SMBIOS/DMI module."""
> >
> >  import bits
> > diff --git a/tests/avocado/acpi-bits/bits-tests/testacpi.py2 
> > b/tests/avocado/acpi-bits/bits-tests/testacpi.py2
> > index dbc150076e..f818a9cce6 100644
> > --- a/tests/avocado/acpi-bits/bits-tests/testacpi.py2
> > +++ b/tests/avocado/acpi-bits/bits-tests/testacpi.py2
> > @@ -1,6 +1,8 @@
> >  # Copyright (c) 2015, Intel Corporation
> >  # All rights reserved.
> >  #
> > +# SPDX-License-Identifier: BSD-3-Clause
> > +#
> >  # Redistribution and use in source and binary forms, with or without
> >  # modification, are permitted provided that the following conditions are 
> > met:
> >  #
> > @@ -24,6 +26,8 @@
> >  # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF 
> > THIS
> >  # SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
> >
> > +# This script runs only from the biosbits VM.
> > +
> >  """Tests for ACPI"""
> >
> >  import acpi
> > diff --git a/tests/avocado/acpi-bits/bits-tests/testcpuid.py2 
> > b/tests/avocado/acpi-bits/bits-tests/testcpuid.py2
> > index ac55d912e1..7adefbe355 100644
> > --- a/tests/avocado/acpi-bits/bits-tests/testcpuid.py2
> > +++ b/tests/avocado/acpi-bits/bits-tests/testcpuid.py2
> > @@ -1,6 +1,8 @@
> >  # Copyright (c) 2012, Intel Corporation
> >  # All rights reserved.
> >  #
> > +# SPDX-License-Identifier: BSD-3-Clause
> > +#
> >  # Redistribution and use in source and binary forms, with or without
> >  # modification, are permitted provided that the following conditions are 
> > met:
> >  #
> > @@ -24,6 +26,8 @@
> >  # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF 
> > THIS
> >  # SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
> >
> > +# This script runs only from the biosbits VM.
> > +
> >  """Tests and helpers for CPUID."""
> >
> >  import bits
> > --
> > 2.34.1
>