Re: [PATCH v2 6/7] i386, mips: Resolve redundant ACPI and APM dependencies

[Bernhard Beschow]

Am 16. Dezember 2022 14:48:05 UTC schrieb BALATON Zoltan <balaton@eik.bme.hu>:
>On Fri, 16 Dec 2022, Bernhard Beschow wrote:
>> Now that all ACPI controllers select the ACPI and APM dependencies
>> themselves, these explicit dependencies became redundant. Remove them.
>> 
>> Signed-off-by: Bernhard Beschow <shentey@gmail.com>
>> ---
>> configs/devices/mips-softmmu/common.mak | 3 ---
>> hw/i386/Kconfig                         | 2 --
>> 2 files changed, 5 deletions(-)
>> 
>> diff --git a/configs/devices/mips-softmmu/common.mak 
>> b/configs/devices/mips-softmmu/common.mak
>> index 416161f833..88aff94625 100644
>> --- a/configs/devices/mips-softmmu/common.mak
>> +++ b/configs/devices/mips-softmmu/common.mak
>> @@ -17,9 +17,7 @@ CONFIG_I8254=y
>> CONFIG_PCSPK=y
>> CONFIG_PCKBD=y
>> CONFIG_FDC=y
>> -CONFIG_ACPI=y
>> CONFIG_ACPI_PIIX4=y
>> -CONFIG_APM=y
>> CONFIG_I8257=y
>> CONFIG_PIIX4=y
>> CONFIG_IDE_ISA=y
>> @@ -32,6 +30,5 @@ CONFIG_MIPS_ITU=y
>> CONFIG_MALTA=y
>> CONFIG_PCNET_PCI=y
>> CONFIG_MIPSSIM=y
>> -CONFIG_ACPI_SMBUS=y
>> CONFIG_SMBUS_EEPROM=y
>> CONFIG_TEST_DEVICES=y
>> diff --git a/hw/i386/Kconfig b/hw/i386/Kconfig
>> index 3a92566701..c4fb5b49bd 100644
>> --- a/hw/i386/Kconfig
>> +++ b/hw/i386/Kconfig
>> @@ -51,7 +51,6 @@ config PC_PCI
>>     bool
>>     select APIC
>>     select IOAPIC
>> -    select APM
>>     select PC
>> 
>> config PC_ACPI
>> @@ -72,7 +71,6 @@ config I440FX
>>     select ACPI_PIIX4
>>     select PC_PCI
>>     select PC_ACPI
>> -    select ACPI_SMBUS
>>     select PCI_I440FX
>>     select PIIX3
>>     select IDE_PIIX
>> 
>
>Is select APM now redundant in VT82686 too?

No it's not, quite the opposite indeed: APM is provided by the VT82686 south 
bridge, so it needs to select it. See also patches 2 and 4 of this series for 
futher explanation.

The idea of this patch is to remove the redundant selections from the boards.

Best regards,
Bernhard

>
>Regards,
>BALATON Zoltan