ratpoison-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[RP] Fix for ratpoison OpenBSD-Port


From: Matthias Kilian
Subject: [RP] Fix for ratpoison OpenBSD-Port
Date: Sat Aug 7 14:09:03 2004
User-agent: Mutt/1.3.28i

Hi,

there's a small problem with ratpoison's unsetenv on OpenBSD: the call
to putenv(3) doesn't work as intended, as it *requires* an argument
containing an equals sign.

I've solved that by using unsetenv(3), but it could also fixed by
appending an equals sign to the argument. Using unsetenv(3) thus seems
to be simpler (no copy/append of a string), but since the ChangeLog
mentions a switch from setenv(3)/unsetenv(3) to putenv(3), YMMV.

Here's the patch:

--- src/actions.c.orig  2004-05-20 07:33:47.000000000 +0200
+++ src/actions.c       2004-08-07 12:30:14.000000000 +0200
@@ -2752,7 +2752,7 @@ cmd_unsetenv (int interactive, char *dat
     }
 
   /* Remove all instances of the env. var. */
-  putenv (data);
+  unsetenv (data);
 
   return NULL;
 }


For William (patch maintainer): it seems to be safe to bump the port to
ratpoison-1.3.0 final.

Ciao,
        Kili



reply via email to

[Prev in Thread] Current Thread [Next in Thread]