ratpoison-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[RP] rpws bug + patch


From: Kenny Billiau
Subject: [RP] rpws bug + patch
Date: Wed, 02 Apr 2008 20:12:28 +0200
User-agent: Thunderbird 2.0.0.9 (X11/20071212)

Hi,

I'm using ratpoison :)
address@hidden bin]# ratpoison --version
ratpoison 1.4.2 (built Oct 17 2007 20:21:03)
Copyright (C) 2000, 2001, 2002, 2003, 2004, 2005, 2006 Shawn Betts

when I started rpws init 4 -k, and went from ws 1 to ws 4, I always got the same windows. I checked wspl var when I was on ws 1 and ws 4, and both times I got "wspl = 1".

address@hidden set
...(truncated)...
_=ratpoison
fspl1='(frame :number 0 :x 0 :y 0 :width 1280 :height 800 :screenw 1280 :screenh 800 :window 0 :last-access 0 :dedicated 0),' fspl2='(frame :number 0 :x 0 :y 0 :width 1280 :height 800 :screenw 1280 :screenh 800 :window 0 :last-access 0 :dedicated 0),' fspl3='(frame :number 0 :x 0 :y 0 :width 1280 :height 800 :screenw 1280 :screenh 800 :window 0 :last-access 0 :dedicated 0),'
wspl=1
...(truncated)...

And as you can see, only three fspl var's have been initialized when starting rpws.
So checking the rpws code, I noticed ws_init() was not initiaing all ws's.

   my $i;
   for( my $i = 1; $i < $num; $i++ )
   {
       ws_init_ws( $i );
   }

which should iterate from 1 to $num, including $num.

So the patch is simple:

--- rpws        2007-10-17 20:21:31.000000000 +0200
+++ rpws.patch  2008-04-02 19:51:22.000000000 +0200
@@ -60,7 +60,7 @@
    rp_call( "only" );

    my $i;
-    for( my $i = 1; $i < $num; $i++ )
+    for my $i (1..$num) {
    {
        ws_init_ws( $i );
    }

kind regards,
Kenny
--- rpws        2007-10-17 20:21:31.000000000 +0200
+++ rpws.patch  2008-04-02 19:51:22.000000000 +0200
@@ -60,7 +60,7 @@
     rp_call( "only" );
 
     my $i;
-    for( my $i = 1; $i < $num; $i++ )
+    for my $i (1..$num) {
     {
         ws_init_ws( $i );
     }


reply via email to

[Prev in Thread] Current Thread [Next in Thread]