Re: [RP] [PATCH] fix swap across multiple screens

[Bernhard R. Link]

* Shawn Betts <address@hidden> [100330 05:56]:
> 2010/3/17 Bernhard R. Link <address@hidden>:
> > exchange_with_frame now always selects the second frame given,
> > simplifying the code (getting rid of segfaults when both were
> > on different screens). This changes the behaviour of cmd_swap
> > to always focus the first argument when two arguments are given.
>
> Would it fix the problem to add a 3rd argument, focusp, so focusing
> the first frame can be controlled?

The problem is that the code for focusing is buggy, especially when
focusing over screen-boundaries. Without focusing, much of the actions
needed for focusing need to be done anyway (updating indicators, bars,
...). (Though for example I'm not sure why switch_frame_hook is run
unconditionally even if no focusing is done).
Just doing the focusing unconditionally makes the code much easier
(20 lines less in exchange_with_frame) and get rid of all those hard
decisions.
The only difference in behaviour visible to the user is that swap with
two arguments (which I do not know if anyone ever did except for testing)
will change focus. In the irc discussion about this issue, people
considered that more natural than not doing it.

Hochachtungsvoll,
        Bernhard R. Link