Re: [RP] [PATCH] Update expose.pl to Work with 1.4.9

[Fahri Cihan Demirci]

On Tue, Nov 14, 2017 at 05:28:19PM +0100, Jeremie Courreges-Anglas wrote:
> On Mon, Nov 13 2017, Fahri Cihan Demirci <address@hidden> wrote:
> > Since after xrandr support was added, sdump returns current screen name,
> > screen number, x-coordinate, y-coordinate, width, height and a boolean
> > flag designating the active screen.
> > This patch changes sdump parsing method in the expose.pl script to
> > accommodate those changes.
> 
> This looks right.  But I wonder if we should really print the screen
> name in sdump.  Or maybe we should print the screen name last, and print
> a dummy name instead of nothing if we don't have xrandr.  The migration
> path looks suboptimal now.
> 
> Cc'ing Mathieu since he's done most of the xrandr work.
> 
> Thoughts?

Having the screen name in sdump could be useful for debugging and
troubleshooting purposes, but that could be stretching it. Certainly
makes the output more readable at first sight, though.

But is staying backwards compatible with regards to the output of sdump
essential? I guess you'd like to introduce no breaking changes unless
necessary, however, I wouldn't consider sdump part of the ratpoison API.
Agree on your point about suboptimal migration, but it is only
marginally suboptimal in my opinion.

> 
> > ---
> >  contrib/expose.pl | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/contrib/expose.pl b/contrib/expose.pl
> > index 0a7127e..4db326b 100644
> > --- a/contrib/expose.pl
> > +++ b/contrib/expose.pl
> > @@ -41,7 +41,7 @@ my $frames_old = &rp('fdump'); chomp $frames_old;
> >  my @r; # Sub-optimal way of grabbing screen x,y,w,h.
> >  
> >  #fixed to use sdump
> > -($_, $r[0], $r[1], $r[2], $r[3]) = split(/ /,&rp ('sdump'));
> > +($_, $_, $r[0], $r[1], $r[2], $r[3], $_) = split(/ /,&rp ('sdump'));
> >  
> >  my $ret = join(", ", &rp_split(address@hidden, \&split, $n, 
> > address@hidden));
> 
> -- 
> jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF  DDCC 0DFA 74AE 1524 E7EE