[bug #58247] sed script in top-level.mk fails to distinguish package names

[Boud Roukema]

URL:
  <https://savannah.nongnu.org/bugs/?58247>

                 Summary: sed script in top-level.mk fails to distinguish
package names
                 Project: Reproducible paper template
            Submitted by: boud
            Submitted on: Sun 26 Apr 2020 02:44:30 PM UTC
                Category: None
                Severity: 3 - Normal
              Item Group: None
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

As in https://gitlab.com/maneage/project/-/merge_requests/2:

Until now, the sed script for determining URL download rules in
reproduce/software/make/high-level.mk considered package names such as
fftw-3... and fftw2-2.1... to be identical. Given that some researchers may
not immediately have time to update and contribute changes upstream to all the
packages that they depend on, there are situations were they may wish to use
both package simultaneously. Moreover, it would be unwise for them to remove
well-established packages from the high-level.mk elif list of download URLs,
even though the user should, in principle, check this list to decide if s/he
accepts those particular URLs to be trustable.

A fix is proposed in the merge request at
https://gitlab.com/maneage/project/-/merge_requests/2

With this commit, the sed script considers fftw-3... and fftw-2... to be
identical, but fftw-3-... and fftw2-2.1... to be different. The older
algorithm worked on single characters; the new one works on the first pair of
characters satisfying the new rule, since the awk selects only the first
word.

I have not tested this directly in the branch off commit cb74bd9fa865d,
because this main branch is much heavier in terms of default software targets
and I haven't (yet) got it fully "configured". I have tested it off the
meneage-paper branch and it works correctly, allowing fftw2 + mpgrafic to be
included.





    _______________________________________________________

Reply to this item at:

  <https://savannah.nongnu.org/bugs/?58247>

_______________________________________________
  Message sent via Savannah
  https://savannah.nongnu.org/