[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Savannah-help-public] Re: log_accum
From: |
Sylvain Beucler |
Subject: |
[Savannah-help-public] Re: log_accum |
Date: |
Tue, 27 Jun 2006 23:07:55 +0200 |
User-agent: |
Mutt/1.5.11+cvs20060403 |
> > - temporary files clean-up: the regexp does not match the files, and
> > does not delete them. I tried fixing it, but I get a weird 'perl -T'
> > warning..
>
> Anything read from the file system or the command line is considered
> tainted in perl's taint mode and when a tainted var is passed to a
> system function (like unlink), perl aborts. Since the grep was matching
> nothing, @files was empty, and the fact that I neglected to untaint the
> output of readdir before passing it to unlink went unnoticed. When you
> fixed the regexp, perl noticed the taint and aborted...
>
> Anyhow, I fixed this.
>
> > - no mail notification when the user did not enter a log message
>
> Simple fix - write_file() was not creating the temp files when it was
> passed an empty array. This behavior wasn't needed anywhere, so I've
> fixed it.
>
> > - in the attached patch, I shortened the credits part, refering people
> > to ChangeLog
>
> Installed.
>
> I also noticed a bug where, when files are committed in multiple
> subdirectories of the top level, but no files are committed from the top
> level (like lib/stdint_.h, m4/stdint.m4), then a slash was missing from
> files in the first directory in the subject line (like "ccvs
> libstdint_.h m4/stdint.m4"). I've installed a fix for this.
Great, I installed the new version. It works fine.
--
Sylvain