[PATCH] determine availability of audio plugins by using config.h

[William Hubbs]

Hi Andrei,

On Sun, Dec 05, 2010 at 08:48:17PM +0100, Andrei Kholodnyi wrote:
> On Sun, Dec 5, 2010 at 7:33 PM, William Hubbs <w.d.hubbs at gmail.com> wrote:
> > Yes, I agree that it adds #ifdefs in the c code, but I don't see a
> > problem with having them in this case. This keeps us from
> > generating a .c file in the configure step and limits what the configure
> > step touches to config.h and the makefiles, which brings us in line with
> > how the autotools are supposed to work imho.
> >
> > Would you please re-consider your position on this patch?
> 
> It took me quite time to get rid of all 1001
> #ifdef MY_FAVORITE_AUDIO_METHOD
> in the source code and make it independent on this stuff.
> 
> I agree that a generating of c file from configure is not the best way.

In that case, we both agree that what we have now is not a good way to
do what we are doing, so I think that this patch starts us moving toward
cleaning that up.

This patch just moves us away from generating a .c file, it does not
stop us from coming up with something like what you suggest below.

> You are more than welcome to invent something better
> e.g. discovery of audio plugins similar to what Trev did.

I'm not quite sure what you mean, but if you are saying to maybe test
for alsa, pulse, etc, I do that in the configure script, and that's the
only place where that could happen because you have to link against
different libraries depending on which sound systems are available.

> The only requirement: it shall be universal,
> i.e. no source code modifications while adding a new audio backend.

We had what I thought was the best way of doing this in OpenTTS. There
wasn't an audio library at all, and all of the backends were plugins.

If we do that here,it would  mean getting rid of libsdaudio entirely and
using lt_dlopen() to load the plugins like we did in OpenTTS.

William

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: 
<http://lists.freebsoft.org/pipermail/speechd/attachments/20101205/cb84e220/attachment.pgp>