[PATCH] Convert audio subsystem to use dynamically-loaded plugins.

[William Hubbs]

Hi Chris,

On Sun, Dec 12, 2010 at 07:31:17PM -0600, William Hubbs wrote:
> Hey Chris,
> 
> I see one thing in this patch.  Now there are two checks for libltdl in
> the configure script, because your patch adds one.
> 
> Should I remove the one you added?

I found a couple of trivial things, which are not a problem (the patch
can go in with these as they are), but I can change them if you want.

The variable audio_dlopen_modules is all upper case in the configure
script, but it doesn't have to be. If you prefer that it stays upper
case, that's fine, just let me know if you want to change it.

I like to make sure I quote everything in m4, just to be safe. You did
not quote the variable in the call to AC_SUBST for audio_dlopen_modules.
It works as is, so I am not rejectingyour patch over this, but if you
are ok with it I would like to change this before I push.

In the makefiles, you use @audio_dlopen_modules@ instead of
$(audio_dlopen_modules). Can I change this?

What do you think about these?

William

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: 
<http://lists.freebsoft.org/pipermail/speechd/attachments/20101212/75571d87/attachment-0001.pgp>