speechd-discuss
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH 3/3] Connect to socket if SPEECHD_ADDRESS begins with /


From: Boris Dušek
Subject: [PATCH 3/3] Connect to socket if SPEECHD_ADDRESS begins with /
Date: Wed, 25 Jul 2012 15:11:29 +0200

25. 7. 2012 v 14:08, Trevor Saunders:

>> Also that is what g_strdup (and any function using g_malloc) does.
> 
> yes, I think the real write patch here may be to not copy the string in
> the first place which I looked into at one point, but it was kind of
> tricky.

true, that's what I nearly always think when I see (g_)strdup of a constant
string in speechd code, except for the cases where different code paths may
need to generate (e.g. g_strdup_printf) a malloc'ed string and the final string
must be consistent from the allocation strategy point of view no matter what
code path it results from.

>> Please let me know if you agree with such a way so that I can post
>> such a patch for final review.
> 
> In an ideal world I don't think libspeechd would just exit from someone
> elses program

well I forgot about this important aspect, so I will not exit but just return 
error


reply via email to

[Prev in Thread] Current Thread [Next in Thread]