speechd-discuss
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH v2 0/3] Portability improvements


From: Boris Dušek
Subject: [PATCH v2 0/3] Portability improvements
Date: Sun, 29 Jul 2012 16:36:59 +0200

From: Boris Dus?ek <address@hidden>
To: address@hidden

This is a second take at a patch series to improve portability
of Speech Dispatcher with changes motivated by OS X.

This incorporates suggestions by Trev as well as some
further refinements by me:

* { on separate line in definitions of safe_{read,write}
* define struct spd_sem_s in header
* make spd_sem_* functions fatal on failure, return void where applicable
* add spd_sem_init that initializes already allocated semaphore, make
  add spd_sem_destroy the corresponding destructive function analogous to
  sem_destroy, and remove spd_sem_create
* move safe_{read,write} to a common header, implementation to a separate file
* get rid of SPD_AUDIO_PLUGIN_ENTRY macros in modules and generate the relevant
  function name in more general macro (see below)
* define a macro to do audio plugin vtable definition and entry point
  definition in one step (SPD_AUDIO_PLUGIN_REGISTER)

Boris Dus?ek (3):
  Remove references to TEMP_FAILURE_RETRY
  Factor out common audio module stuff into a macro
  Abstract unnamed semaphore

 include/spd_utils.h            |   21 ++++++++++-
 src/audio/alsa.c               |   22 ++----------
 src/audio/libao.c              |   20 ++---------
 src/audio/nas.c                |   23 ++----------
 src/audio/oss.c                |   22 ++----------
 src/audio/pulse.c              |   21 ++---------
 src/audio/spd_audio_plugin_p.h |   46 ++++++++++++++++++++++++
 src/clients/say/say.c          |   19 ++++------
 src/clients/spdsend/server.c   |    5 ++-
 src/common/Makefile.am         |    2 +-
 src/common/spd_safeio.c        |   48 +++++++++++++++++++++++++
 src/common/spd_sem.c           |   76 ++++++++++++++++++++++++++++++++++++++++
 src/modules/cicero.c           |   17 +++++----
 src/modules/dummy.c            |   12 +++----
 src/modules/espeak.c           |   34 +++++++++---------
 src/modules/festival.c         |   14 ++++----
 src/modules/flite.c            |   15 ++++----
 src/modules/generic.c          |   14 ++++----
 src/modules/ibmtts.c           |   52 +++++++++++++--------------
 src/modules/ivona.c            |   15 ++++----
 src/modules/pico.c             |   30 ++++++++--------
 src/server/output.c            |   15 +-------
 src/server/sem_functions.c     |    6 ++--
 src/server/speaking.c          |    8 ++---
 24 files changed, 320 insertions(+), 237 deletions(-)
 create mode 100644 src/audio/spd_audio_plugin_p.h
 create mode 100644 src/common/spd_safeio.c
 create mode 100644 src/common/spd_sem.c

-- 
1.7.9.6 (Apple Git-31.1)




reply via email to

[Prev in Thread] Current Thread [Next in Thread]