[Straw-devel] Re: link/guid behaviour, feedparser changes and tracking upstream

[Juri Pakaste]

On Mon, 2004-06-28 at 17:55 +1000, Jan Alonzo wrote:
> Juri Pakaste <address@hidden> writes:
> 
> > I had to change feedparser and SummaryParser a bit to get us what I see
> > as the correct behaviour with links and guids.
> >
> > First of all, our version of feedparser now saves the guidislink
> > attribute (in RSS, it's the isPermalink attribute of the guid element.)
> > That'll mean we can't use an externally installed feedparser library,
> > but so be it. It's not the first time I've had to make that change; this
> > time, I preceded it with a comment starting with "straw:". That's
> > probably a good idea in other places too where we have to make changes
> > to source code that tries to track an upstream source, it'll make it
> > possible for us to grep for local changes. 
> >
> 
> Ermm... If you read the feedparser docs, it stores '<guid>' in 'link' _if_
> isPermalink is present so we don't have to do that.

But if isPermalink="true" (or if isPermalink is absent, which means the
same thing) and <link> is present, guid isn't in the link attribute and
we have a different link, no? Then there's no way to know if we should
still show guid?
-- 
[ Juri Pakaste | address@hidden | http://www.iki.fi/juri/ ]

signature.asc
Description: This is a digitally signed message part