Re: [STUMP] [PATCH] A mode-line group display/switching widget.

[Shawn Betts]

Joel Fernandes <address@hidden> writes:

> It would be great to have this made a part of stumpwm. I am open to
> any feedback and am excited about people using it.

This looks neat! I have a small recommendation. The following
functions have a global sounding names but are only used once. I think
they should either go in the correct file or become labels funtions in
the functions that use them. Since they seem somewhat special purpose,
at least at this point, labels are probably best.

+(defun group-mode-lines (group)
+  (mapcar (lambda (head) (head-mode-line head))
+          (screen-heads (group-screen group))))
+
+(defun group-exists-p (group)
+  (and (find group (screen-groups (group-screen group))) t))

Also, have you managed to get double buffering working? If so, toss us the 
patch :).

-Shawn