texinfo-commits
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[no subject]

From: Gavin D. Smith
Date: Wed, 30 Nov 2022 13:36:37 -0500 (EST) 
branch: old/qt-info
commit 72329552d18bc09551cbe23552192230402de240
Author: Gavin Smith <gavinsmith0123@gmail.com>
AuthorDate: Wed Apr 10 16:31:00 2019 +0100

    Reduce ambiguity of "index".
    
    (config) <INDEX_NAME>: Rename to TOP_NAME.
    <INDEX_ID>: Rename to TOP_ID.
    (init_index_page, init_top_page): Rename.
    (inside_index_page, inside_top_page): Rename variable.
    (on_load, Pages):
    Comments and variable names changed to refer to "top" instead of
    "index".
    
    This tries to leave the word "index" used for the indices of the
    manual only.
---
 ChangeLog  |  4 ++++
 js/info.js | 26 +++++++++++++-------------
 2 files changed, 17 insertions(+), 13 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 9ddb0783de..cfd4d42e46 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -5,6 +5,10 @@
        (config) <INDEX_NAME>: Rename to TOP_NAME.
        <INDEX_ID>: Rename to TOP_ID.
        (init_index_page, init_top_page): Rename.
+       (inside_index_page, inside_top_page): Rename variable.
+       (on_load, Pages):
+       Comments and variable names changed to refer to "top" instead of 
+       "index".
 
        This tries to leave the word "index" used for the indices of the 
        manual only.
diff --git a/js/info.js b/js/info.js
index 8ec20fca33..7078faa6a1 100644
--- a/js/info.js
+++ b/js/info.js
@@ -729,16 +729,16 @@
     | Component for the pages.  |
     `--------------------------*/
 
-    /** @arg {HTMLDivElement} index_div */
+    /** @arg {HTMLDivElement} top_div */
     function
-    Pages (index_div)
+    Pages (top_div)
     {
-      index_div.setAttribute ("id", config.TOP_ID);
-      index_div.setAttribute ("node", config.TOP_ID);
-      index_div.setAttribute ("hidden", "true");
+      top_div.setAttribute ("id", config.TOP_ID);
+      top_div.setAttribute ("node", config.TOP_ID);
+      top_div.setAttribute ("hidden", "true");
       this.element = document.createElement ("div");
       this.element.setAttribute ("id", "sub-pages");
-      this.element.appendChild (index_div);
+      this.element.appendChild (top_div);
       /** @type {string[]} Currently created divs.  */
       this.ids = [config.TOP_ID];
       /** @type {string} */
@@ -1009,10 +1009,10 @@
       document.body.classList.add ("mainbar");
 
       /* Move contents of <body> into a a fresh <div> to let the components
-         treat the index page like other iframe page.  */
-      var index_div = document.createElement ("div");
+         treat the top page like other iframe page.  */
+      var top_div = document.createElement ("div");
       for (var ch = document.body.firstChild; ch; ch = 
document.body.firstChild)
-        index_div.appendChild (ch);
+        top_div.appendChild (ch);
 
       /* Aggregation of all the sub-components.  */
       var components = {
@@ -1047,7 +1047,7 @@
         }
       };
 
-      components.add (new Pages (index_div));
+      components.add (new Pages (top_div));
       components.add (new Sidebar ());
       components.add (new Help_page ());
       components.add (new Minibuffer ());
@@ -2019,11 +2019,11 @@
   config = Object.assign (config, user_config);
 
   var inside_iframe = top !== window;
-  var inside_index_page = window.location.pathname === config.TOP_NAME
+  var inside_top_page = window.location.pathname === config.TOP_NAME
       || window.location.pathname.endsWith ("/" + config.TOP_NAME)
       || window.location.pathname.endsWith ("/");
 
-  if (inside_index_page)
+  if (inside_top_page)
     {
       var initial_state = {
         /* Dictionary associating page ids to next, prev, up, forward,
@@ -2085,7 +2085,7 @@ var core;
 // qwebchannel.js has been loaded.
 wc_init = function ()
 {
-  if (!inside_index_page)
+  if (!inside_top_page)
     return;
 
   if (location.search != "")
reply via email to
[Prev in Thread] Current Thread [Next in Thread]