Re: Info reader fails to find cross-references to anchors

[Eli Zaretskii]

> Date: Sat, 18 Jul 2015 16:41:10 +0100
> From: Gavin Smith <address@hidden>
> Cc: address@hidden
> 
> On 18 July 2015 at 09:57, Eli Zaretskii <address@hidden> wrote:
> > There was one more problem with this in Texinfo 6.0, which seems to be
> > specific to MS-Windows: find_node_from_tag unconditionally overwrites
> > the nodelen value of tags for anchors with -1, thus losing the only
> > indication it has that the tag entry is an anchor.  This caused any
> > cross-reference to an anchor to fail.
> >
> > I fixed this in Texinfo 6.0 like this:
> >
> > -          (*t)->nodelen = -1;
> > +         /* NODELEN zero means this is an anchor, so this value
> > +            doesn't need to be adjusted, and we shouldn't lose it, as
> > +            it's the only indication of an anchor. */
> > +         if ((*t)->nodelen != 0)
> > +           (*t)->nodelen = -1;
> >
> > The current trunk introduced a cache, and does that for the cached
> > entry, but I believe a similar change is still due, i.e. n->nodelen
> > should only be set to -1 for non-anchor tag entries.
> 
> You mean like this?

Probably.  I admit I don't yet have a clear idea what is this cache
about.

> I think this is right, the fact that more data is being shared between
> nodes displayed in windows and in window histories doesn't change the
> point that much.
> 
> The property of being an anchor should probably be expressed through a
> flag instead of reusing the nodelen field.

That's okay, but then that flag should remain set in a similar way,
since you otherwise zero out the whole node structure here.

Thanks.