Re: [Tinycc-devel] Request code review

[Sia Lang]

jiang,

My suggestion:

1. Learn english properly, it's very hard to understand your comments

2. Learn the tcc code base properly, then ask for small patch reviews to get things started

- Sia

On Wed, Jun 4, 2014 at 4:09 PM, jiang <address@hidden> wrote:

Hey Thomas Preud'homme

Thank you.
Your machine information sent on the arm, I will slowly study.
That bug is very strange, when I gave tcc increase vls code appeared, then I will update you tccelf.c not appeared. Since tcc-g debugging weak, to find the problem more difficult.

I live in Hengyang

jiang

On Tuesday, June 03, 2014 09:56:38 AM David Mertens wrote:

Hey jiang,

Hi there,

I didn't read the patch yet (and anyway, I want to get a grasp on what has
been going on in the past month or so before looking at that patch) but I'd
like to add a few words.


First of all, a few words for you Jiang. I saw you did many commits recently
and I would like to thank you for your effort in trying to improve tinycc.
People have mostly complained so far because that's how it work in our
community but I, at least, appreciate that you are trying to help.

That being said, as other said before me I think your commits could be
improved. I think David already gave you some very good advices about this,
advices that are valid in the wider community, not only for tinycc. I won't
repeat them all here, but the first one is to observe how things currently work
and try to fit in. If you are unsure, fill free to ask question but be patient
as they aren't many people working on tcc and we are not very available. For
instance, try to follow the coding rule used by the project. I know it's not
very easy for tcc as they vary on a per-file basis: some file use 4 spaces
indentation, some others only 2.

Also try to phrase your comments and commit message as well as you can because
these words will stay for people later to understand the why a change was
made. Also don't make a change if you are not sure to understand all the
consequences. I did this mistake many times myself and I'm slowly learning to
do better.


David, your turn now. I'll be quick. I'd just like to thank you for chiming in
and try to help Jiang join our community. I know I've been really absent
recently and I'm glad you took time to give him so many hints.

I'll try to come back progressively but won't be able to commit any thing for
still a few (2-3?) weeks I think but at least I'll start to review what
happened and tell if I see something broken. There is a few thing I'd really
lack to do:

* finish the work I started to improve cross-compilation with tcc
* release tcc 0.9.27
* setup an automated testsuite run on GCC farm for i386, x86-64 and arm
(softfloat and hardfloat)

I'm also wondering if some people would be interested in having a tinycc IRC
channel. I'm not entirely sure it's a good idea as we are very few regular
developers and not all will want to participate. I also think mailing list
present the advantage of being archived and being read by more people (no
timezone problem there) so a chat might not be a very good idea. But it's
worth thinking about it.

That's all for today.

Cheers everybody,

Thomas

_______________________________________________
Tinycc-devel mailing list
address@hidden
https://lists.nongnu.org/mailman/listinfo/tinycc-devel