[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Tinycc-devel] Source vandalism
From: |
Vincent Lefevre |
Subject: |
Re: [Tinycc-devel] Source vandalism |
Date: |
Wed, 29 Jul 2015 15:14:31 +0200 |
User-agent: |
Mutt/1.5.23-6474-vl-r81210 (2015-07-27) |
On 2015-07-29 08:56:47 -0400, gus knight wrote:
> On Wed, Jul 29, 2015 at 8:50 AM, Michael Matz <address@hidden> wrote:
> > P.S: some of the reindendation changes look like as if you've replaced
> > leading tabs with four spaces. That would have been wrong, tabs are eight
> > spaces. If this is the case, fix your editor settings.
>
> In some of the cases, it's obvious that whoever wrote the code was
> using 4 spaces per tab, but in others it's obvious they were using 8.
> It was kind of hard to determine which, and I had to second-guess
> about the surrounding code.
Anyway, tabs are incorrect: with tabs, various tools break
indentation, such as "diff" (thus patches may be difficult
to read) and "git blame".
--
Vincent Lefèvre <address@hidden> - Web: <https://www.vinc17.net/>
100% accessible validated (X)HTML - Blog: <https://www.vinc17.net/blog/>
Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon)