[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Tinycc-devel] TinyCC in macOS
From: |
Michael Matz |
Subject: |
Re: [Tinycc-devel] TinyCC in macOS |
Date: |
Tue, 28 Mar 2017 18:09:41 +0200 (CEST) |
User-agent: |
Alpine 2.20 (LSU 67 2015-01-07) |
Hi,
On Tue, 28 Mar 2017, Andrei E. Warkentin wrote:
> Dear tinycc-devel,
>
> Found your mailing list today looking for macOS support for TCC. I have
> some good news, in the form of a patch that enables '-run' mode and a patch
> consisting of clang warning fixes. This should allow for further work to be
> done, as in adding proper Mach-O support.
>
> Don't know the procedures you folks have for doing code reviews, but I've
> my own branch (https://github.com/andreiw/tinycc) which I just forked from
> the mob one. At the very least, it provides a good way of looking at the
> changes.
>
> https://github.com/andreiw/tinycc/commit/e733d489f015c2e9df3a43e975c82276a4823ee5
> (tcc: early OSX native support)
Merge this one.
> https://github.com/andreiw/tinycc/commit/302fbde543a5347daa6ee93aa98733260b2e3d29
> (tcc: fixup clang warnings)
I think introducing LINE_MACRO_OUTPUT_FORMAT_P10 for the hack of accepting
-P10 is not worth it. The cast you had to add for the O() macro in
i386-asm.c: I noticed this as well somewhen with clang which doesn't
notice that the values in question never overflow. If a cast to int works
as well please use that. Otherwise merge it as well.
Ciao,
Michael.