toon-members
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Toon-members] [edrosten/TooN] 8114f8: Fix intermediate rotations in SO3


From: Gerhard Reitmayr
Subject: [Toon-members] [edrosten/TooN] 8114f8: Fix intermediate rotations in SO3 constructor
Date: Sat, 01 Nov 2014 04:56:22 -0700

  Branch: refs/heads/master
  Home:   https://github.com/edrosten/TooN
  Commit: 8114f8a94b7f5691036722af909e360348d21ac7
      
https://github.com/edrosten/TooN/commit/8114f8a94b7f5691036722af909e360348d21ac7
  Author: Alastair Harrison <address@hidden>
  Date:   2014-10-28 (Tue, 28 Oct 2014)

  Changed paths:
    M so3.h

  Log Message:
  -----------
  Fix intermediate rotations in SO3 constructor

- This applies to the SO3 constructor that takes two vectors ‘a’ and ‘b’
  as arguments and computes the rotation matrix that brings vector ‘a’
  into the direction of vector ‘b’.
- Previously the intermediate rotation matrices used to compute the
  final result were not valid elements of SO3, since they had
  negative determinants.
- This fix does not alter the final result of the function, but it does
  ensure that the intermediate results are valid rotation matrices.


  Commit: e9dc76ad791f2102ae6c1fd8ef9a7c6e8ee0b16c
      
https://github.com/edrosten/TooN/commit/e9dc76ad791f2102ae6c1fd8ef9a7c6e8ee0b16c
  Author: Gerhard Reitmayr <address@hidden>
  Date:   2014-11-01 (Sat, 01 Nov 2014)

  Changed paths:
    M so3.h

  Log Message:
  -----------
  Merge pull request #5 from aharrison24/so3fix

Fix intermediate rotations in SO3 constructor


Compare: https://github.com/edrosten/TooN/compare/5824193b7f81...e9dc76ad791f

reply via email to

[Prev in Thread] Current Thread [Next in Thread]