Re: [tpop3d-discuss] tpop3d 1.5.1pre2 (with TLS support)

[Chris Lightfoot]

On Thu, Nov 14, 2002 at 12:49:38PM +0100, Angel Marin wrote:
> Ok I've seen something interesting.
> 
> It is the difference between what a failing mail looks like on the server
> and what client finally receives (OE6). "OiA8QSBIUkVGPWh0dHA6Ly93d3cuY" is
> sent twice.

Oops. That's not good.... Is it reproducible?

> This has happened on a non TLS config, with TLS the same meassage failed.
> With non TLS there was no error, but the client received a modified message
> content.

OK. I've found another potential problem in the buffer
code, which I've fixed in CVS; alternatively, the diff is

--- buffer.c    13 Nov 2002 20:08:59 -0000      1.3
+++ buffer.c    14 Nov 2002 12:00:42 -0000      1.4
@@ -139,7 +139,7 @@
         size_t i;
         char *newbuf;
         size_t newlen;
-        for (newlen = B->len * 2; newlen < a + num; newlen *= 2);
+        for (newlen = B->len * 2; newlen <= a + num; newlen *= 2);
         newbuf = xmalloc(newlen);
         for (i = 0; i < a; ++i)
             newbuf[i] = B->buf[(B->get + i) % B->len];

(You'll notice that this is, in fact, the same bug as before but in a different
place. So I can't count.)

-- 
If we couldn't laugh at things that didn't make sense,
we couldn't react to a lot of the world around us. (Calvin and Hobbes)