Re: [tpop3d-discuss][PATCH]: poll for tpop3d

[Arkadiusz Miskiewicz]

On Saturday 24 June 2006 19:46, Chris Lightfoot wrote:
> On Thu, Jun 22, 2006 at 08:28:04PM +0200, Arkadiusz Miskiewicz wrote:

> > > applied in CVS, with a poll(2) wrapper and autoconf test.
> > > Please test ;-)
> >
> > Version from cvs works for me.  There is one thing in my patch which
> > could be nicer - match existing code like using xcalloc and xfree instead
> > of malloc and free.
> >
> > ps. another patch for consideration:
> > http://cvs.pld-linux.org/cgi-bin/cvsweb/SOURCES/tpop3d-disable-dotfile-lo
> >cking.patch by address@hidden
>
> Now also applied in CVS.

Please apply this one, too:
http://cvs.pld-linux.org/cgi-bin/cvsweb/SOURCES/tpop3d-poll.patch?rev=1.10

It fixes:
- use poll when available (right now we were always using select fallback)
- fix for case when revents contain more than one event (I guess that's 
possible)
- set descriptors to -1 so kernel can skip them when doing poll()
- the second parameter of poll is highest possible index in an array (no need 
to +1)

-- 
Arkadiusz Miśkiewicz        PLD/Linux Team
arekm / maven.pl            http://ftp.pld-linux.org/